linux-kernel - Re: [PATCH] usb_wwan: fix build error in play

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110322164454.GB15916@suse.de>
Date:	Tue, 22 Mar 2011 09:44:54 -0700
From:	Greg KH <gregkh@...e.de>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Tao Ma <tm@....ma>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb_wwan: fix build error in play_delayed.

On Tue, Mar 22, 2011 at 07:05:55AM +0100, Eric Dumazet wrote:
> Le mardi 22 mars 2011 à 12:29 +0800, Tao Ma a écrit :
> > From: Tao Ma <boyu.mt@...bao.com>
> > 
> > There is a build error in today's linus tree.
> > drivers/usb/serial/usb_wwan.c: In function ‘play_delayed’:
> > drivers/usb/serial/usb_wwan.c:702: error: ‘struct dev_pm_info’ has no member named ‘usage_count’
> > The reason is that usage_count is wrapped with macro CONFIG_PM_RUNTIME
> > now in dev_pm_info.
> > 
> > So use the corresponding pm_runtime_get_noresume instead.
> > 
> > Cc: Greg Kroah-Hartman <gregkh@...e.de>
> > Signed-off-by: Tao Ma <boyu.mt@...bao.com>
> > ---
> >  drivers/usb/serial/usb_wwan.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/usb/serial/usb_wwan.c b/drivers/usb/serial/usb_wwan.c
> > index a65ddd5..5858ce4 100644
> > --- a/drivers/usb/serial/usb_wwan.c
> > +++ b/drivers/usb/serial/usb_wwan.c
> > @@ -699,7 +699,7 @@ static void play_delayed(struct usb_serial_port *port)
> >  			do {
> >  				unbusy_queued_urb(urb, portdata);
> >  				//extremely dirty
> > -				atomic_dec(&port->serial->interface->dev.power.usage_count);
> > +				pm_runtime_get_noresume(&port->serial->interface->dev);
> >  			} while ((urb = usb_get_from_anchor(&portdata->delayed)));
> >  			break;
> >  		}
> 
> Oh well, thats the third time this patch is sent

Yes, sorry, been busy with other stuff, this will get fixed soon, I have
enough copies of it in my queue :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/