[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <E1Q264S-0001Fy-HU@pomaz-ex.szeredi.hu>
Date: Tue, 22 Mar 2011 19:12:44 +0100
From: Miklos Szeredi <miklos@...redi.hu>
To: Linus Torvalds <torvalds@...ux-foundation.org>
CC: miklos@...redi.hu, viro@...iv.linux.org.uk,
linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
akpm@...ux-foundation.org, apw@...onical.com, nbd@...nwrt.org,
neilb@...e.de
Subject: Re: [PATCH 1/6 v7] vfs: add i_op->open()
On Tue, 22 Mar 2011, Linus Torvalds wrote:
> > + struct inode *inode = nd->path.dentry->d_inode;
> > +
> > + if (inode->i_op->open) {
> > + int flags = filp->f_flags;
> > + put_filp(filp);
> > + filp = inode->i_op->open(nd->path.dentry, flags, cred);
> > + } else {
> > + filp = __dentry_open(&nd->path, filp, NULL, cred);
> > + }
>
> This seems broken.
>
> Why don't you just pass in the filp to the ->open routine, and drop
> that "flags" argument. Maybe other filesystems want to use ->open, but
> don't want to put_filp() on the filp we already allocated, only to
> allocate a new one?
Maybe, although I don't see the reason to do that. Why keep the
original one? It doesn't contain any information besides the flags
and the dentry/vfsmount.
Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists