linux-kernel - Re: checkpatch: introduce --nocs to disable CodingStyle warnings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1300825261.24885.35.camel@Joe-Laptop>
Date:	Tue, 22 Mar 2011 13:21:01 -0700
From:	Joe Perches <joe@...ches.com>
To:	Dave Jones <davej@...hat.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	Jonathan Corbet <corbet@....net>,
	Andy Whitcroft <apw@...dowen.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: checkpatch: introduce --nocs to disable CodingStyle warnings.

On Tue, 2011-03-22 at 15:58 -0400, Dave Jones wrote:
> How about this ?  running checkpatch with --nocs will now only print
> non-CodingStyle related warnings.   I may have missed some of the
> conversions, but this seems to silence the more egregious 'noise'.
> Signed-off-by: Dave Jones <davej@...hat.com>

Hi Dave.

Trivia only:

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 58848e3..a2b0086 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -19,6 +19,7 @@ my $tree = 1;
>  my $chk_signoff = 1;
>  my $chk_patch = 1;
>  my $tst_only;
> +my $nocs = 0;

To match the other checkpatch control flag uses,
I think this would be better as:

my $chk_style = 1;

> @@ -55,6 +56,7 @@ Options:

+  --style               display warnings about CodingStyle.

etc...

> @@ -80,6 +82,7 @@ GetOptions(
>  
>  	'debug=s'	=> \%debug,
>  	'test-only=s'	=> \$tst_only,
> +	'nocs'		=> \$nocs,

'style!' => \$chk_style,

etc...

And the command line use would be --nostyle

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/