linux-kernel - Re: [PATCH 1/7] char/mei: PCI device and char driver support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110322222259.GA26362@suse.de>
Date:	Tue, 22 Mar 2011 15:22:59 -0700
From:	Greg KH <gregkh@...e.de>
To:	Alan Cox <alan@...ux.intel.com>
Cc:	Arnd Bergmann <arnd@...db.de>, Oren Weil <oren.jer.weil@...el.com>,
	linux-kernel@...r.kernel.org, david@...dhou.se
Subject: Re: [PATCH 1/7] char/mei: PCI device and char driver support.

On Tue, Mar 22, 2011 at 09:57:59PM +0000, Alan Cox wrote:
> > * In the PCI probe function, create a misc character device for
> >   every instance you find behind each device. Remove the global
> >   variables and constants.
> 
> The current code is complex and could be a ton simpler *but* don't
> abuse misc devices when you have one per PCI instance please.

The code specifically says it only supports one device in the system at
a time.  Since it can't do any more than that, why wouldn't it be
correct for a misdevice to be used here?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/