linux-kernel - Re: [PATCH] Add secdata to unix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110322163204.3bc29a76.rdunlap@xenotime.net>
Date:	Tue, 22 Mar 2011 16:32:04 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Pat Kane <pekane52@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Add secdata to unix_streams.

On Tue, 22 Mar 2011 18:27:02 -0500 Pat Kane wrote:

> The unix_dgram routines add secdata to socket message,
> but the unix_stream routines do not.  We add the two
> missing lines of code.

Please copy netdev@...r.kernel.org on networking patches.

We who?  :)

> Signed-off-by: Pat Kane <pekane52@...il.com>
> ---
>  net/unix/af_unix.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
> index 1663e1a..3873523 100644
> --- a/net/unix/af_unix.c
> +++ b/net/unix/af_unix.c
> @@ -1642,6 +1642,8 @@ static int unix_stream_sendmsg(struct kiocb *kiocb, struct socket *sock,
>  		max_level = err + 1;
>  		fds_sent = true;
>  
> +                unix_get_secdata(siocb->scm, skb);
> +
>  		err = memcpy_fromiovec(skb_put(skb, size), msg->msg_iov, size);
>  		if (err) {
>  			kfree_skb(skb);
> @@ -1930,6 +1932,7 @@ static int unix_stream_recvmsg(struct kiocb *iocb, struct socket *sock,
>  		} else {
>  			/* Copy credentials */
>  			scm_set_cred(siocb->scm, UNIXCB(skb).pid, UNIXCB(skb).cred);
> +                        unix_set_secdata(siocb->scm, skb);
>  			check_creds = 1;
>  		}
>  
> -- 

gmail (?) mucked up the indentation tabs -- they are all spaces.  Not good.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/