linux-kernel - Re: [GIT PULL] First round of SCSI updates for 2.6.38 merge window

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1fwqfu6dd.fsf@sermon.lab.mkp.net>
Date:	Tue, 22 Mar 2011 00:27:42 -0400
From:	"Martin K. Petersen" <martin.petersen@...cle.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	James Bottomley <James.Bottomley@...e.de>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] First round of SCSI updates for 2.6.38 merge window

>>>>> "Geert" == Geert Uytterhoeven <geert@...ux-m68k.org> writes:

Geert> drivers/scsi/sd.c: In function ‘sd_prep_fn’:
Geert> drivers/scsi/sd.c:544: warning: ‘ret’ may be used uninitialized
Geert> in this function

Sorry about that.


sd: Fail discard requests when logical block provisioning has been disabled

Ensure that we kill discard requests after logical block provisioning
has been disabled in sysfs.

Signed-off-by: Martin K. Petersen <martin.petersen@...cle.com>
Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 3be5db5..7ff61d7 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -597,6 +597,7 @@ static int scsi_setup_discard_cmnd(struct scsi_device *sdp, struct request *rq)
 		break;
 
 	default:
+		ret = BLKPREP_KILL;
 		goto out;
 	}
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/