linux-kernel - Re: [PATCH 1/7] char/mei: PCI device and char driver support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201103230859.12759.arnd@arndb.de>
Date:	Wed, 23 Mar 2011 08:59:12 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Greg KH <gregkh@...e.de>, Alan Cox <alan@...ux.intel.com>,
	Oren Weil <oren.jer.weil@...el.com>,
	linux-kernel@...r.kernel.org, david@...dhou.se
Subject: Re: [PATCH 1/7] char/mei: PCI device and char driver support.

On Wednesday 23 March 2011, Alan Cox wrote:
> On Tue, 22 Mar 2011 15:22:59 -0700
> Greg KH <gregkh@...e.de> wrote:
> 
> > On Tue, Mar 22, 2011 at 09:57:59PM +0000, Alan Cox wrote:
> > > > * In the PCI probe function, create a misc character device for
> > > >   ". Remove the global
> > > >   variables and constants.
> > > 
> > > The current code is complex and could be a ton simpler but don't
> > > abuse misc devices when you have one per PCI instance please.
> > 
> > The code specifically says it only supports one device in the system at
> > a time.  Since it can't do any more than that, why wouldn't it be
> > correct for a misdevice to be used here?
> 
> Arnd was suggesting one device for "every instance you find behind each
> device" so that isn't a good idea for a misc device given there will be
> lots of them.

Yes, makes sense. I was assuming that the common case was that there
is only a single instance.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/