linux-kernel - Re: [PATCH 2/7] TTY: serial_core, remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTim3XGC5EuHEdNqchQmWmcerXpnKCKZ3SbaibmXQ@mail.gmail.com>
Date:	Wed, 23 Mar 2011 14:45:31 +0530
From:	Govindraj <govindraj.ti@...il.com>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	jirislaby@...il.com, linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-serial@...r.kernel.org
Subject: Re: [PATCH 2/7] TTY: serial_core, remove unused variable

On Wed, Mar 23, 2011 at 2:19 PM, Jiri Slaby <jslaby@...e.cz> wrote:
> drivers/tty/serial/serial_core.c:1980:2: warning: Value stored to 'tty' is never read
>        tty = port->tty;
>        ^     ~~~~~~~~~
>
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>


Acked-by: Govindraj.R <govindraj.raja@...com>


> Cc: Greg Kroah-Hartman <gregkh@...e.de>
> Cc: linux-serial@...r.kernel.org
> ---
>  drivers/tty/serial/serial_core.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index 733fe8e..d6e7240 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -1972,13 +1972,9 @@ int uart_suspend_port(struct uart_driver *drv, struct uart_port *uport)
>        struct tty_port *port = &state->port;
>        struct device *tty_dev;
>        struct uart_match match = {uport, drv};
> -       struct tty_struct *tty;
>
>        mutex_lock(&port->mutex);
>
> -       /* Must be inside the mutex lock until we convert to tty_port */
> -       tty = port->tty;
> -
>        tty_dev = device_find_child(uport->dev, &match, serial_match_port);
>        if (device_may_wakeup(tty_dev)) {
>                if (!enable_irq_wake(uport->irq))
> --
> 1.7.4.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-serial" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/