linux-kernel - Re: [PATCH 3/3] params.c: Use new kstrtobool implementation to processing boolean inputs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D89F8D0.7070108@cam.ac.uk>
Date:	Wed, 23 Mar 2011 13:42:40 +0000
From:	Jonathan Cameron <jic23@....ac.uk>
To:	Jonathan Cameron <jic23@....ac.uk>
CC:	linux-kernel@...r.kernel.org, greg@...ah.com,
	rusty@...tcorp.com.au, adobriyan@...il.com
Subject: Re: [PATCH 3/3] params.c: Use new kstrtobool implementation to processing
 boolean inputs.

Oops. The patch title should probably make sense.

On 03/23/11 13:39, Jonathan Cameron wrote:
> Signed-off-by: Jonathan Cameron <jic23@....ac.uk>
> ---
>  kernel/params.c |   15 ++++-----------
>  1 files changed, 4 insertions(+), 11 deletions(-)
> 
> diff --git a/kernel/params.c b/kernel/params.c
> index 0da1411..37b4d83 100644
> --- a/kernel/params.c
> +++ b/kernel/params.c
> @@ -297,3 +297,4 @@ EXPORT_SYMBOL(param_ops_charp);
>  int param_set_bool(const char *val, const struct kernel_param *kp)
>  {
>  	bool v;
> +	int ret;
> 
>  	/* No equals means "set"... */
>  	if (!val) val = "1";
>  
>  	/* One of =[yYnN01] */
> -	switch (val[0]) {
> -	case 'y': case 'Y': case '1':
> -		v = true;
> -		break;
> -	case 'n': case 'N': case '0':
> -		v = false;
> -		break;
> -	default:
> -		return -EINVAL;
> -	}
> +	ret = kstrtobool(val, &v);
> +	if (ret)
> +		return ret;
>  
>  	if (kp->flags & KPARAM_ISBOOL)
>  		*(bool *)kp->arg = v;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/