linux-kernel - Re: [RFC] usbnet: use eth%d name for known ethernet devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201103231811.54290.arnd@arndb.de>
Date:	Wed, 23 Mar 2011 18:11:53 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	andy.green@...aro.org
Cc:	Greg KH <greg@...ah.com>, Alan Cox <alan@...rguk.ukuu.org.uk>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Nicolas Pitre <nicolas.pitre@...aro.org>,
	Jaswinder Singh <jaswinder.singh@...aro.org>,
	Linux USB list <linux-usb@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	broonie@...nsource.wolfsonmicro.com, roger.quadros@...ia.com,
	grant.likely@...retlab.ca, netdev@...r.kernel.org,
	David Brownell <dbrownell@...rs.sourceforge.net>
Subject: Re: [RFC] usbnet: use eth%d name for known ethernet devices

On Wednesday 23 March 2011, Andy Green wrote:
> > diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
> > index bc86f4b..c98d3a7 100644
> > --- a/drivers/net/usb/smsc95xx.c
> > +++ b/drivers/net/usb/smsc95xx.c
> > @@ -1231,7 +1231,7 @@ static const struct driver_info smsc95xx_info = {
> 
> > -     .flags          = FLAG_ETHER | FLAG_SEND_ZLP,
> > +     .flags          = FLAG_ETHER | FLAG_SEND_ZLP | FLAG_REALLY_ETHER,
> 
> >               if ((dev->driver_info->flags&  FLAG_ETHER) != 0&&
> > +                 ((dev->driver_info->flags&  FLAG_PTP) == 0 ||
> > +                  (net->dev_addr [0]&  0x02) == 0))
> >                       strcpy (net->name, "eth%d");
> 
> So it just takes the approach that all smsc95xx are going to be eth%d? 

Right, and all other drivers that are obviously ethernet-only, including
future drivers.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/