linux-kernel - Re: [RFC] usbnet: use eth%d name for known ethernet devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D8A33BA.6020501@ti.com>
Date:	Wed, 23 Mar 2011 12:54:02 -0500
From:	David Anders <x0132446@...com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	Greg KH <greg@...ah.com>,
	"andy.green@...aro.org" <andy.green@...aro.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Nicolas Pitre <nicolas.pitre@...aro.org>,
	Jaswinder Singh <jaswinder.singh@...aro.org>,
	Linux USB list <linux-usb@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	"broonie@...nsource.wolfsonmicro.com" 
	<broonie@...nsource.wolfsonmicro.com>,
	"roger.quadros@...ia.com" <roger.quadros@...ia.com>,
	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	David Brownell <dbrownell@...rs.sourceforge.net>
Subject: Re: [RFC] usbnet: use eth%d name for known ethernet devices

On 03/23/2011 12:13 PM, Arnd Bergmann wrote:
> On Wednesday 23 March 2011, Arnd Bergmann wrote:
>    
>> --- a/drivers/net/usb/smsc75xx.c
>> +++ b/drivers/net/usb/smsc75xx.c
>> @@ -1244,7 +1244,7 @@ static const struct driver_info smsc75xx_info = {
>>          .rx_fixup       = smsc75xx_rx_fixup,
>>          .tx_fixup       = smsc75xx_tx_fixup,
>>          .status         = smsc75xx_status,
>> -       .flags          = FLAG_ETHER | FLAG_SEND_ZLP,
>> +       .flags          = FLAG_ETHER | FLAG_SEND_ZLP | FLAG_REALLY_ETHER,
>>   };
>>
>>   static const struct usb_device_id products[] = {
>> diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
>> index bc86f4b..c98d3a7 100644
>> --- a/drivers/net/usb/smsc95xx.c
>> +++ b/drivers/net/usb/smsc95xx.c
>> @@ -1231,7 +1231,7 @@ static const struct driver_info smsc95xx_info = {
>>          .rx_fixup       = smsc95xx_rx_fixup,
>>          .tx_fixup       = smsc95xx_tx_fixup,
>>          .status         = smsc95xx_status,
>> -       .flags          = FLAG_ETHER | FLAG_SEND_ZLP,
>> +       .flags          = FLAG_ETHER | FLAG_SEND_ZLP | FLAG_REALLY_ETHER,
>>   };
>>
>>      
> These two hunks are from an earlier version of the patch and should not
> be there, they break compilation. I'll wait for more comments and
> then send a fixed version.
>
> 	Arnd
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>    

tested with 2.6.38 using omap2plus_defconfig with EHCI and smsc95xx 
turned on minus the FLAG_REALLY_ETHER. appears to work properly, assigns 
as eth0.

i ran some basic net tests with no issues.


Dave Anders



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/