linux-kernel - Re: [PATCH][RFC] Null short-circuit for selinux_cred

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1103232207120.20169@swampdragon.chaosbits.net>
Date:	Wed, 23 Mar 2011 22:07:38 +0100 (CET)
From:	Jesper Juhl <jj@...osbits.net>
To:	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
cc:	linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][RFC] Null short-circuit for selinux_cred_free()

On Wed, 23 Mar 2011, Tetsuo Handa wrote:

> Jesper Juhl wrote:
> > Let selinux_cred_free accept NULL pointers.
> No need to do so.
> 
> > If we don't do this, then we can crash if someone manages to pass NULL to 
> > cred_free. Seems to me it's better to just do nothing in that case rather 
> > than crash.
> If cred == NULL, put_cred_rcu(NULL) causes the kernel to panic before calling
> LSM hooks.

Good point. Thanks.

-- 
Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/