linux-kernel - Re: [PATCH]Clean up CodingStyle for scripts/kconfig/gconf.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110323070017.GA3731@gmail.com>
Date:	Wed, 23 Mar 2011 15:00:20 +0800
From:	Harry Wei <jiaweiwei.xiyou@...il.com>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org, greg@...ah.com,
	akpm@...ux-foundation.org
Subject: Re: [PATCH]Clean up CodingStyle for scripts/kconfig/gconf.c

On Wed, Mar 23, 2011 at 09:28:48AM +0800, Li Zefan wrote:
> Harry Wei wrote:
> > Hi us,
> >    	Clean up CodingStyle for scripts/kconfig/gconf.c.
> > 
> 
> What makes you think this is a bad style? Does Documentation/CodingStyle say
> so? Does checkpatch.pl make a complain? Do you really think this improves
> readability? I don't think so, and actually it makes the code worse.
But we all write '#include <***>'. I have never seen '#  include <***>'.
> 
> Run checkpatch.pl on this file, and you'll see lots of errors and warnings,
> but pure codingstyle cleanup is rarely worth anything, so better don't do
> that.
I am sorry, I have not got your meaning clearly.
> 
> > Thanks.
> > Best Regards.
> > Harry Wei.
> > 
> > Signed-off-by: Harry Wei <harryxiyou@...il.com>
> > ---
> >  scripts/kconfig/gconf.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
> > index 4558961..56da945 100644
> > --- a/scripts/kconfig/gconf.c
> > +++ b/scripts/kconfig/gconf.c
> > @@ -7,7 +7,7 @@
> >   */
> >  
> >  #ifdef HAVE_CONFIG_H
> > -#  include <config.h>
> > +#include <config.h>
> >  #endif
> >  
> >  #include "lkc.h"
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/