linux-kernel - Re: [PATCH 0/1] m68k: merge m68k and m68knommu arch directories

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D8B3102.1080205@snapgear.com>
Date:	Thu, 24 Mar 2011 21:54:42 +1000
From:	Greg Ungerer <gerg@...pgear.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
CC:	<linux-m68k@...r.kernel.org>, <uclinux-dev@...inux.org>,
	<linux-kernel@...r.kernel.org>,
	Linux-Next <linux-next@...r.kernel.org>
Subject: Re: [PATCH 0/1] m68k: merge m68k and m68knommu arch directories


Hi Geert,

On 24/03/11 18:06, Geert Uytterhoeven wrote:
> On Thu, Mar 24, 2011 at 00:00, Greg Ungerer<gerg@...pgear.com>  wrote:
>> On 24/03/11 08:07, Geert Uytterhoeven wrote:
>>> On Tue, Mar 22, 2011 at 05:43,<gerg@...pgear.com>  Ã¡wrote:
>>>> slso on the for-next branch in that tree, so will get some testing
>>>> in the next tree for the next few days.
>>>
>>> defconfig is now a nommu-config, and it fails?
>>>
>>> http://kisskb.ellerman.id.au/kisskb/buildresult/4012794/
>>
>> Yep, that looks wrong. I'll move the define for KBUILD_DEFCONFIG
>> into arch/m68k/Makefile (and remove the existing defines in Makefile_mm
>> and Makefile_no). That will make the DEFCONFIG as it was before,
>> multi_defconfig.
>>
>>> arch/m68k/kernel/entry_no.S:47: Error: Unknown operator -- statement
>>> `save_all' ignored
>>
>> This is due to compiling for the non-mmu targets and not using
>> a m68k-uclinux- toolchain. Unfortunately the compiler must define
>> __uClinux__ to compile for non-mmu targets. This isn't new, we
>
> For userland...

Yes, they can't see CONFIG_MMU or otherwise.


>> have had this problem ever since the merge of the header files.
>> (The exported headers need some switch to use to base some
>> conditionals on, and kernel config options cannot be used in
>> exported headers).
>
> For kernels, we can explicitly define this in arch/m68k/Makefile if !MMU, right?

We certainly can do that, but we don't currently...
I'll make a note to fix that.


>> But with a fixed defconfig, you won't see this anymore :-)
>>
>> I'll fix up the git commit on m68knommu git tree.
>
> Good, thx!

That is updated... Do you want to let this bake for another couple
of days before I ask Linus to pull it?

Regards
Greg


> Gr{oetje,eeting}s,
>
> Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡Ã¡ Ã¡Ã¡ -- Linus Torvalds
>
>
>


-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@...pgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/