linux-kernel - Re: [PATCH v3 1/7] mfd: add pruss mfd driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <384BC720F8C741B886DC000F067EBA20@subhasishg>
Date:	Thu, 24 Mar 2011 18:46:22 +0530
From:	"Subhasish Ghosh" <subhasish@...tralsolutions.com>
To:	"Marc Kleine-Budde" <mkl@...gutronix.de>
Cc:	<davinci-linux-open-source@...ux.davincidsp.com>,
	<sachi@...tralsolutions.com>,
	"Samuel Ortiz" <sameo@...ux.intel.com>, <nsekhar@...com>,
	"open list" <linux-kernel@...r.kernel.org>, <m-watkins@...com>,
	<linux-arm-kernel@...ts.infradead.org>,
	"Stalin Srinivasan" <stalin.s@...tralsolutions.com>
Subject: Re: [PATCH v3 1/7] mfd: add pruss mfd driver.

Hello,

> A device may be de-initialized and another loaded or two different devices
> can be run simultaneously on the two cores.
> It's also possible, as in our case, to implement a single device on both
> the PRU's resulting in improved load sharing.

>Make you driver compile with sparse "make C=1", you cast way too much
>when accessing io mem. Use void __iomem * instead of u32 *.


With make C=1 I am receiving some warnings such as:

warning: cast removes address space of expression
drivers/mfd/da8xx_pru.c:61:17: warning: incorrect type in argument 1 
(different base types)
drivers/mfd/da8xx_pru.c:61:17:    expected void const volatile [noderef] 
<asn:2>*<noident>
drivers/mfd/da8xx_pru.c:61:17:    got int
drivers/mfd/da8xx_pru.c:66:28: warning: incorrect type in argument 1 
(different address spaces)

I can remove all of these by casting to (__force void  __iomem *) but is 
this correct.

-SG 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/