linux-kernel - Re: [PATCH 2/2] hid-ntrig: calibration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1103241531130.19969@pobox.suse.cz>
Date:	Thu, 24 Mar 2011 15:32:00 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Henrik Rydberg <rydberg@...omail.se>
Cc:	Rafi Rubin <rafi@...s.upenn.edu>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, micki@...rig.com, chatty@...c.fr,
	dmitry.torokhov@...il.com
Subject: Re: [PATCH 2/2] hid-ntrig: calibration

On Mon, 21 Mar 2011, Henrik Rydberg wrote:

> > Adding a function to tell the device to run its calibration routine.
> > A number written to the sysfs specifies the duration of the calibration
> > in milliseconds
> > 
> > Signed-off-by: Rafi Rubin <rafi@...s.upenn.edu>
> > ---
> 
> This is great functionality, and from what it seems, it works. However, 
> the poking at the usb layer makes me wonder if there is another way... 
> Jiri? Dmitry? Awaiting answers from someone more knowledgeable, please 
> find some comments inline.

Actually, let me put it another way -- is there any reason not to have 
this as a functionality provided by HID core code (with driver registering 
callbacks if they want to provide calibration functionality)?

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/