linux-kernel - Re: [patch 1/3] arm/gpio: Remove three copies of broken and racy debug code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1103242342030.31464@localhost6.localdomain6>
Date:	Thu, 24 Mar 2011 23:43:15 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Ryan Mallon <ryan@...ewatersys.com>
cc:	LKML <linux-kernel@...r.kernel.org>,
	Grant Likely <grant.likely@...retlab.ca>
Subject: Re: [patch 1/3] arm/gpio: Remove three copies of broken and racy
 debug code


On Fri, 25 Mar 2011, Ryan Mallon wrote:

> On 03/25/2011 10:27 AM, Thomas Gleixner wrote:
> > gpiolib plus two gpio implementations in arm fiddle in the guts of
> > irq_desc in a racy and buggy way. Remove the stuff. I already told the
> > gpio folks that we can provide that information in a proper way if
> > necessary.
> >
> > Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> > ---
> >  arch/arm/mach-ep93xx/gpio.c  |   39 -------------------------------------
> >  arch/arm/plat-nomadik/gpio.c |   45 -------------------------------------------
> >  drivers/gpio/gpiolib.c       |   45 -------------------------------------------
> >  3 files changed, 129 deletions(-)
> >
> > Index: linux-2.6-tip/arch/arm/mach-ep93xx/gpio.c
> > ===================================================================
> 
> I suggested an alternative patch for the ep93xx last time round which
> keeps the information that the pin is configured as an interrupt and
> tidies the code a bit (moves the newline to the first seq_printf). My
> patch is available here:
> http://lists-archives.org/linux-kernel/27439434-arm-ep93xx-kill-another-instance-of-broken-irq_desc-fiddling.html
> 
> Could we merge that instead please.

Sure. Will pick it up.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/