linux-kernel - Re: [PATCH 2/2] futex: Fix WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1301045758.2250.154.camel@laptop>
Date:	Fri, 25 Mar 2011 10:35:58 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	Darren Hart <dvhart@...ux.intel.com>,
	Richard Weinberger <richard@....at>
Subject: Re: [PATCH 2/2] futex: Fix WARN_ON() test for UP

On Thu, 2011-03-17 at 15:21 -0400, Steven Rostedt wrote:
> From: Steven Rostedt <srostedt@...hat.com>
> 
> An update of the futex code had a
> 
>         WARN_ON(!spin_is_locked(q->lock_ptr))
> 
> But on UP, spin_is_locked() is always false, and will
> trigger this warning, and even worse, it will exit the function
> without doing the necessary work.
> 
> Converting this to a WARN_ON_SMP() fixes the problem.
> 
> Reported-by: Richard Weinberger <richard@....at>
> Tested-by: Richard Weinberger <richard@....at>
> Signed-off-by: Steven Rostedt <rostedt@...dmis.org> 

Acked-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/