linux-kernel - suspect code in cyasblkdev_block conversion to bdops->check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <check-events-cyasblkdev-block-suspect@mdm.bga.com>
Date:	Fri, 25 Mar 2011 06:48:03 -0400
From:	Milton Miller <miltonm@....com>
To:	Tejun Heo <tj@...nel.org>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, Jens Axboe <axboe@...nel.dk>,
	Kay Sievers <kay.sievers@...y.org>,
	David Cross <david.cross@...ress.com>,
	linux-kernel@...r.kernel.org
Subject: suspect code in cyasblkdev_block conversion to bdops->check_events()

> commit cafb0bfca1a73efd6d8a4a6a6a716e6134b96c24
> Author: Tejun Heo <tj@...nel.org>
> Commit: Tejun Heo <tj@...nel.org>
> 
>     staging: Convert to bdops->check_events()
>     
>     Convert two staging drivers - blkvsc_drv and cyasblkdev_block - from
>     ->media_changed() to ->check_events().  The former always indicated
>     media changed while the latter always indicated media not changed.
>     Not sure what the drivers are trying to achieve but keep the original
>     behavior.
>     
>     Signed-off-by: Tejun Heo <tj@...nel.org>
>     Acked-by: Greg Kroah-Hartman <gregkh@...e.de>
>     Cc: Jens Axboe <axboe@...nel.dk>
>     Cc: Kay Sievers <kay.sievers@...y.org>
> 
..
> diff --git a/drivers/staging/westbridge/astoria/block/cyasblkdev_block.c b/drivers/staging/westbridge/astoria/block/cyasblkdev_block.c
> index e1851f0..842cd92 100644
..
> @@ -1090,6 +1090,7 @@ static int cyasblkdev_add_disks(int bus_num,
>  		bd->user_disk_0->first_minor = devidx << CYASBLKDEV_SHIFT;
>  		bd->user_disk_0->minors = 8;
>  		bd->user_disk_0->fops = &cyasblkdev_bdops;
> +		bd->user_disk_0->events = DISK_EVENT_MEDIA_CHANGE;
>  		bd->user_disk_0->private_data = bd;
>  		bd->user_disk_0->queue = bd->queue.queue;
>  		bd->dbgprn_flags = DBGPRN_RD_RQ;
> @@ -1190,6 +1191,7 @@ static int cyasblkdev_add_disks(int bus_num,
>  		bd->user_disk_1->first_minor = (devidx + 1) << CYASBLKDEV_SHIFT;
>  		bd->user_disk_1->minors = 8;
>  		bd->user_disk_1->fops = &cyasblkdev_bdops;
> +		bd->user_disk_0->events = DISK_EVENT_MEDIA_CHANGE;
>  		bd->user_disk_1->private_data = bd;
Date: Fri, 25 Mar 2011 04:48:01 -0600
X-Originating-IP: 71.22.127.106

The 0 on the above line triggered my suspect code pattern detector.

>  		bd->user_disk_1->queue = bd->queue.queue;
>  		bd->dbgprn_flags = DBGPRN_RD_RQ;
> @@ -1278,6 +1280,7 @@ static int cyasblkdev_add_disks(int bus_num,
>  				(devidx + 2) << CYASBLKDEV_SHIFT;
>  			bd->system_disk->minors = 8;
>  			bd->system_disk->fops = &cyasblkdev_bdops;
> +			bd->system_disk->events = DISK_EVENT_MEDIA_CHANGE;
>  			bd->system_disk->private_data = bd;
>  			bd->system_disk->queue = bd->queue.queue;
>  			/* don't search for vfat

milton
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/