linux-kernel - RE: [PATCH] gpio: ml_ioh_gpio: Fix output value of ioh_gpio_direction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1301064421.24947.231.camel@petert>
Date:	Fri, 25 Mar 2011 09:47:01 -0500
From:	Peter Tyser <ptyser@...-inc.com>
To:	Tomoya MORINAGA <tomoya-linux@....okisemi.com>
Cc:	linux-kernel@...r.kernel.org,
	"'Grant Likely'" <grant.likely@...retlab.ca>,
	Toshiharu Okada <toshiharu-linux@....okisemi.com>
Subject: RE: [PATCH] gpio: ml_ioh_gpio: Fix output value of
 ioh_gpio_direction_output()

Hi Tomoya,

On Fri, 2011-03-25 at 09:31 +0900, Tomoya MORINAGA wrote:
> Hi Peter,
> 
> On Friday, March 25, 2011 8:17 AM, Peter Tyser wrote:
> 
> > The ioh_gpio_direction_output() function was missing a write 
> > to set the desired output value.  The function would properly 
> > set the GPIO direction, but not the output value.  The value 
> > would have to manually be set with a follow up call to ioh_gpio_set().
> 
> > This is untested - just noticed it while working on an 
> > unrelated change.  An ack or tested-by from someone with real 
> > hardware would be appreciated.
> 
> Thank you for your indication.
> Your saying is right.
> However since your patch looks incorrect,
> after testing, I will post new patch by next week.

Out of curiosity, what looks incorrect about the patch?  The code to set
the GPIO value is identical to the code in ioh_gpio_set(), which was the
old code path.

Best,
Peter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/