linux-kernel - Re: [GIT PULL] Core block IO bits for 2.6.39

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Mar 2011 17:01:09 +0100
From:	Jens Axboe <jaxboe@...ionio.com>
To:	Markus Trippelsdorf <markus@...ppelsdorf.de>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Chris Mason <chris.mason@...cle.com>
Subject: Re: [GIT PULL] Core block IO bits for 2.6.39 - early Oops

On 2011-03-25 16:58, Markus Trippelsdorf wrote:
> On 2011.03.25 at 16:51 +0100, Jens Axboe wrote:
>> On 2011-03-25 15:28, Markus Trippelsdorf wrote:
>>> On 2011.03.25 at 15:20 +0100, Jens Axboe wrote:
>>>> On 2011-03-25 15:14, Markus Trippelsdorf wrote:
>>>>> On 2011.03.25 at 15:10 +0100, Jens Axboe wrote:
>>>>>> On 2011-03-25 14:09, Markus Trippelsdorf wrote:
>>>>>>> On 2011.03.25 at 13:44 +0100, Jens Axboe wrote:
>>>>>>>> On 2011-03-25 10:57, Markus Trippelsdorf wrote:
>>>>>>>>>
>>>>>>>>> Reverting it solves all problems here.
>>>>>>>>
>>>>>>>> Can you try this one?
>>>>>>>
>>>>>>> This one doesn't help; I still get the same BUG.
>>>>>>>
>>>>>>> BTW if you're having trouble reproducing this, here is the only non
>>>>>>> stock xfs option that I use on the affected partitions:
>>>>>>>
>>>>>>> noatime,logbsize=262144
>>>>>>
>>>>>> This?
>>>>>
>>>>> No.
>>>>
>>>> Lets expand the scope a bit, this one?
>>>
>>> No. And setting CONFIG_PREEMPT_NONE also doesn't help.
>>>
>>
>> Does this work? I'm actually relieved that the preempt was a red
>> herring. I had earlier convinced myself that it was all safe without
>> that mucking around with preempt counts.
> 
> Finally: YES. 
> Many thanks Jens.

Awesome. And thanks goes to you for doing tons of testing and having a
rapid turn-around time, and to Sergey for finding the right commit that
allowed a genuine fix.

I'll prepare a pull for Linus immediately.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/