linux-kernel - Re: [PATCH 2/2] eeepc-wmi: Add support for T101MT Home/Express Gate key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110325161405.GC5099@core.coreip.homeip.net>
Date:	Fri, 25 Mar 2011 09:14:05 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Corentin Chary <corentin.chary@...il.com>
Cc:	Chris Bagwell <chris@...bagwell.com>,
	Matthew Garrett <mjg@...hat.com>,
	acpi4asus-user@...ts.sourceforge.net,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	Seth Forshee <seth.forshee@...onical.com>
Subject: Re: [PATCH 2/2] eeepc-wmi: Add support for T101MT Home/Express Gate
 key

On Fri, Mar 25, 2011 at 02:05:18PM +0000, Corentin Chary wrote:
> On Fri, Mar 25, 2011 at 1:53 PM, Seth Forshee
> <seth.forshee@...onical.com> wrote:
> >
> > I guess it depends on what key events we want on a press-and-hold.
> > Remember that you're going to get a scan code sequence like "0xe4 0xea
> > 0xea ... 0xea 0xe5", so with my implementation you get
> >
> >  KEY_PROG2 press
> >  KEY_PROG2 release
> >
> > With yours
> >
> >  KEY_HOME press
> >  KEY_PROG2 press
> >  KEY_PROG2 release
> >  // KEY_PROG2 press/release repeats every 0.5 secs while button held
> >  KEY_HOME release
> >
> > At minimum I'd think we'd want to only send a single PROG2 press/release
> > for button hold. My thought was that you'd only want to get the code for
> > 0xe4 or 0xea, not both, but I suppose that's debatable.
> 
> If you keep a keyboard key pressed, you want multiple events, not one right ?
> I think it's important not to loose informations. If someone keep this
> key pressed more than 1.5 second, I think it's good idea to send
> multiple KEY_PROG2.

You can have input autorepeat facilities do that for you. If you want to
do this yourself then the proper value for repeated events is _2_, not
1, or they will be dropped as duplicates.

> 
> About KEY_HOME press / release, and filtering KEY_HOME after
> KEY_PROG2, I'm not sure. So if you really want it, and nobody
> complains, I'll be happy to accept your patch.
> 
> > And back to the question of KEY_HOME -- that's not really what you want,
> > is it? As in "move cursor to start of line"?
> 
> Ho .. right, that's what mean KEY_HOME :/. So no, I don't want that...
> What about:
> - KEY_CYCLEWINDOWS
> - KEY_COMPUTER
> - KEY_HOMEPAGE
> - KEY_DASHBOARD
> 
> I think KEY_HOMEPAGE is the best choice.

No, KEY_HOMEPAGE should cause your browser to go to your home page. What
you want is either:

#define KEY_CONFIG         171     /* AL Consumer Control Configuration */
#define KEY_DASHBOARD      204     /* AL Dashboard */

("AL" stands for "Application Launcher", "AC" for 'Application Control",
matched loosely to HUT tables).

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/