linux-kernel - Re: [PATCH 2/2] eeepc-wmi: Add support for T101MT Home/Express Gate key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110325162850.GD14328@thinkpad-t410>
Date:	Fri, 25 Mar 2011 11:28:50 -0500
From:	Seth Forshee <seth.forshee@...onical.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Corentin Chary <corentin.chary@...il.com>,
	Chris Bagwell <chris@...bagwell.com>,
	Matthew Garrett <mjg@...hat.com>,
	acpi4asus-user@...ts.sourceforge.net,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] eeepc-wmi: Add support for T101MT Home/Express Gate
 key

On Fri, Mar 25, 2011 at 09:14:05AM -0700, Dmitry Torokhov wrote:
> > If you keep a keyboard key pressed, you want multiple events, not one right ?
> > I think it's important not to loose informations. If someone keep this
> > key pressed more than 1.5 second, I think it's good idea to send
> > multiple KEY_PROG2.
> 
> You can have input autorepeat facilities do that for you. If you want to
> do this yourself then the proper value for repeated events is _2_, not
> 1, or they will be dropped as duplicates.
> 
> > 
> > About KEY_HOME press / release, and filtering KEY_HOME after
> > KEY_PROG2, I'm not sure. So if you really want it, and nobody
> > complains, I'll be happy to accept your patch.
> > 
> > > And back to the question of KEY_HOME -- that's not really what you want,
> > > is it? As in "move cursor to start of line"?
> > 
> > Ho .. right, that's what mean KEY_HOME :/. So no, I don't want that...
> > What about:
> > - KEY_CYCLEWINDOWS
> > - KEY_COMPUTER
> > - KEY_HOMEPAGE
> > - KEY_DASHBOARD
> > 
> > I think KEY_HOMEPAGE is the best choice.
> 
> No, KEY_HOMEPAGE should cause your browser to go to your home page. What
> you want is either:
> 
> #define KEY_CONFIG         171     /* AL Consumer Control Configuration */
> #define KEY_DASHBOARD      204     /* AL Dashboard */
> 
> ("AL" stands for "Application Launcher", "AC" for 'Application Control",
> matched loosely to HUT tables).

Dmitry,

I didn't see you responses before my last response, so you can ignore
it. Let me make sure I understand correctly. For reference, the button
in question sends an 0xe4 scancode on press, repeated 0xea scancodes on
hold, and 0xe5 on release.

So, would the following make sense (KEY_TBD is may abbreviation for "key
to be determinded"):

 - On press (0xe4), send KEY_TBD, value = 1
 - On hold (0xea), send KEY_TBD, value = 2
 - On release (0xe5), send KEY_TBD, value = 0

Also, is KEY_CYCLEWINDOWS intended to imply screen rotation, or
something else?

Thanks,
Seth

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/