linux-kernel - Re: [PATCHv3] usb: core: Change usb_create_sysfs_intf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1103251302410.2047-100000@iolanthe.rowland.org>
Date:	Fri, 25 Mar 2011 13:03:12 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Michal Nazarewicz <mina86@...a86.com>
cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
	Chris Wright <chrisw@...s-sol.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv3] usb: core: Change usb_create_sysfs_intf_files()' return
 type to void

On Fri, 25 Mar 2011, Michal Nazarewicz wrote:

> The usb_create_sysfs_intf_files() function always returned zero even
> if it failed to create sysfs fails.  Since this is a desired behaviour
> there is no need to return return code at all.  This commit changes
> function's return type (form int) to void.
> 
> Signed-off-by: Michal Nazarewicz <mina86@...a86.com>
> Cc: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> ---
>  drivers/usb/core/sysfs.c |   13 +++++--------
>  drivers/usb/core/usb.c   |    3 +--
>  drivers/usb/core/usb.h   |    2 +-
>  3 files changed, 7 insertions(+), 11 deletions(-)
> 
> On Fri, 25 Mar 2011 16:33:12 +0100, Alan Stern <stern@...land.harvard.edu> wrote:
> > My style preference is to put the empty statement before the comment.
> > It's unusual to have a comment appearing before a statement on the same
> > line.  For example:
> >		;	/* We don't care if the function fails */
> 
> Changed.  And I agree, it looks better now. :)

Acked-by: Alan Stern <stern@...land.harvard.edu>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/