linux-kernel - Re: [boot crash #2] Re: [GIT PULL] SLAB changes for v2.6.39-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110325200003.GC7346@elte.hu>
Date:	Fri, 25 Mar 2011 21:00:03 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Pekka Enberg <penberg@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Christoph Lameter <cl@...ux.com>,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	tj@...nel.org, npiggin@...nel.dk, rientjes@...gle.com,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [boot crash #2] Re: [GIT PULL] SLAB changes for v2.6.39-rc1


* Pekka Enberg <penberg@...nel.org> wrote:

> On Thu, Mar 24, 2011 at 9:22 PM, Ingo Molnar <mingo@...e.hu> wrote:
> >
> > * Thomas Gleixner <tglx@...utronix.de> wrote:
> >
> >> On Thu, 24 Mar 2011, Ingo Molnar wrote:
> >> > RIP: 0010:[<ffffffff810570a9>]  [<ffffffff810570a9>] get_next_timer_interrupt+0x119/0x260
> >>
> >> That's a typical timer crash, but you were unable to debug it with
> >> debugobjects because commit d3f661d6 broke those.
> >>
> >> Christoph, debugobjects do not need to run with interupts
> >> disabled. And just because they were in that section to keep all the
> >> debug stuff together does not make an excuse for not looking at the
> >> code and just slopping it into some totally unrelated ifdef along with
> >> a completely bogus comment.
> >>
> >> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> >> ---
> >>  mm/slub.c |    4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> Index: linux-2.6/mm/slub.c
> >> ===================================================================
> >> --- linux-2.6.orig/mm/slub.c
> >> +++ linux-2.6/mm/slub.c
> >> @@ -849,11 +849,11 @@ static inline void slab_free_hook(struct
> >>               local_irq_save(flags);
> >>               kmemcheck_slab_free(s, x, s->objsize);
> >>               debug_check_no_locks_freed(x, s->objsize);
> >> -             if (!(s->flags & SLAB_DEBUG_OBJECTS))
> >> -                     debug_check_no_obj_freed(x, s->objsize);
> >>               local_irq_restore(flags);
> >>       }
> >>  #endif
> >> +     if (!(s->flags & SLAB_DEBUG_OBJECTS))
> >> +             debug_check_no_obj_freed(x, s->objsize);
> >
> > Thanks, this did the trick!
> >
> > Tested-by: Ingo Molnar <mingo@...e.hu>
> >
> > With this fix i got the warning below - pinpointing a net/bluetooth/hci_core.c
> > timer bug.
> 
> Applied, thanks!

Just an update: all SLAB/SLUB problems appear to be fixed with the latest 
patches, so i'm a happy camper!

Thanks Pekka,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/