linux-kernel - Re: [PATCH] x86_64: Fix page table building regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTikqDbY+W7cXRwFrQg5DSToZYgXn8xGVQK9g3D4R@mail.gmail.com>
Date:	Sat, 26 Mar 2011 02:19:58 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>, greg@...ah.com,
	stable@...nel.org
Cc:	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86_64: Fix page table building regression

On Fri, Mar 25, 2011 at 11:43 PM, Eric W. Biederman
<ebiederm@...ssion.com> wrote:
>
> Recently I had cause to enable PAGE_ALLOC_DEBUG and I discovered my
> kdump kernel would not boot.  After some investigation it turns out that
> in commit 80989ce064 "x86: clean up and and print out initial max_pfn_mapped"
> that a limitation of the 32bit page table setup was unnecessarily
> applied to the 64bit code.  The initial 64bit page table setup code is
> careful to map in it's initial page table pages and unmap then when done
> so they can live anywhere in memory, so we don't need to limit ourselves
> to using pages that are already mapped into memory.
>
> In my case I hit this because the first 512M was not usable by the
> kdump kernel.

We have one completed fix in mainline already.

We need that patch for 2.6.38 stable tree.

that patch is supposed to be for 2.6.38, but is delayed to 2.6.39.

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=4b239f458c229de044d6905c2b0f9fe16ed9e01e

x86-64, mm: Put early page table high

While dubug kdump, found current kernel will have problem with crashkernel=512M.

It turns out that initial mapping is to 512M, and later initial mapping to 4G
(acutally is 2040M in my platform), will put page table near 512M.
then initial mapping to 128g will be near 2g.

before this patch:
[    0.000000] initial memory mapped : 0 - 20000000
[    0.000000] init_memory_mapping: [0x00000000000000-0x0000007f74ffff]
[    0.000000]  0000000000 - 007f600000 page 2M
[    0.000000]  007f600000 - 007f750000 page 4k
[    0.000000] kernel direct mapping tables up to 7f750000 @
[0x1fffc000-0x1fffffff]
[    0.000000]     memblock_x86_reserve_range: [0x1fffc000-0x1fffdfff]
         PGTABLE
[    0.000000] init_memory_mapping: [0x00000100000000-0x0000207fffffff]
[    0.000000]  0100000000 - 2080000000 page 2M
[    0.000000] kernel direct mapping tables up to 2080000000 @
[0x7bc01000-0x7bc83fff]
[    0.000000]     memblock_x86_reserve_range: [0x7bc01000-0x7bc7efff]
         PGTABLE
[    0.000000] RAMDISK: 7bc84000 - 7f745000
[    0.000000] crashkernel reservation failed - No suitable area found.

after patch:
[    0.000000] initial memory mapped : 0 - 20000000
[    0.000000] init_memory_mapping: [0x00000000000000-0x0000007f74ffff]
[    0.000000]  0000000000 - 007f600000 page 2M
[    0.000000]  007f600000 - 007f750000 page 4k
[    0.000000] kernel direct mapping tables up to 7f750000 @
[0x7f74c000-0x7f74ffff]
[    0.000000]     memblock_x86_reserve_range: [0x7f74c000-0x7f74dfff]
         PGTABLE
[    0.000000] init_memory_mapping: [0x00000100000000-0x0000207fffffff]
[    0.000000]  0100000000 - 2080000000 page 2M
[    0.000000] kernel direct mapping tables up to 2080000000 @
[0x207ff7d000-0x207fffffff]
[    0.000000]     memblock_x86_reserve_range:
[0x207ff7d000-0x207fffafff]          PGTABLE
[    0.000000] RAMDISK: 7bc84000 - 7f745000
[    0.000000]     memblock_x86_reserve_range: [0x17000000-0x36ffffff]
    CRASH KERNEL
[    0.000000] Reserving 512MB of memory at 368MB for crashkernel
(System RAM: 133120MB)

It means with the patch, page table for [0, 2g) will need 2g, instead
of under 512M,
page table for [4g, 128g) will be near 128g, instead of under 2g.

That would good, if we have lots of memory above 4g, like 1024g, or
2048g or 16T, will not put
related page table under 2g. that would be have chance to fill the
under 2g if 1G or 2M page is
not used.

the code change will use add map_low_page() and update
unmap_low_page() for 64bit, and use them
to get access the corresponding high memory for page table setting.

...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/