linux-kernel - Re: [PATCH] slub: Disable the lockless allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110326195722.GA7748@elte.hu>
Date:	Sat, 26 Mar 2011 20:57:22 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Christoph Lameter <cl@...ux.com>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	Pekka Enberg <penberg@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	tj@...nel.org, npiggin@...nel.dk, rientjes@...gle.com,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH] slub: Disable the lockless allocator


* Christoph Lameter <cl@...ux.com> wrote:

> On Sat, 26 Mar 2011, Christoph Lameter wrote:
> 
> > Tejun: Whats going on there? I should be getting offsets into the per cpu
> > area and not kernel addresses.
> 
> Its a UP kernel running on dual Athlon. So its okay ... Argh.... The
> following patch fixes it by using the fallback code for cmpxchg_double:
> 
> 
> 
> Subject: per_cpu: Fixup cmpxchg_double for !SMP
> 
> cmpxchg_double should only be provided for SMP. In the UP case
> the GS register is not defined and the function will fail.
> 
> Signed-off-by: Christoph Lameter <cl@...ux.com>

I.e. the bug got introduced by:

 | commit b9ec40af0e18fb7d02106be148036c2ea490fdf9
 | Author: Christoph Lameter <cl@...ux.com>
 | Date:   Mon Feb 28 11:02:24 2011 +0100
 |
 |     percpu, x86: Add arch-specific this_cpu_cmpxchg_double() support

and then the lockless allocator made use of it, right?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/