lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.1103280913170.6625@axis700.grange>
Date:	Mon, 28 Mar 2011 09:16:33 +0200 (CEST)
From:	Guennadi Liakhovetski <g.liakhovetski@....de>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
cc:	Chris Ball <cjb@...top.org>, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-sh@...r.kernel.org,
	linux-mmc@...r.kernel.org
Subject: [PATCH] mmc: SDHI should depend on SUPERH || ARCH_SHMOBILE

Fix build breakage on platforms, not providing readsw and writesw
functions, e.g., on x86(_64).

Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@....de>
---

Subject: Re: linux-next: build failure after merge of the mmc tree

On Mon, 28 Mar 2011, Stephen Rothwell wrote:

> Hi Chris,
> 
> After merging the mmc tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/mmc/host/tmio_mmc_pio.c: In function 'sd_ctrl_read16_rep':
> drivers/mmc/host/tmio_mmc_pio.c:56: error: implicit declaration of function 'readsw'
> drivers/mmc/host/tmio_mmc_pio.c: In function 'sd_ctrl_write16_rep':
> drivers/mmc/host/tmio_mmc_pio.c:73: error: implicit declaration of function 'writesw'
> 
> Presumably caused by commit b6147490e6aa ("mmc: tmio: split core
> functionality, DMA and MFD glue").
> 
> I have used the mmc tree from next-20110325 for tdoay.

Stephen, please verify, that this fixes your problem.

 drivers/mmc/host/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 0b03cee..94df405 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -452,6 +452,7 @@ config MMC_TMIO
 
 config MMC_SDHI
 	tristate "SH-Mobile SDHI SD/SDIO controller support"
+	depends on SUPERH || ARCH_SHMOBILE
 	select MMC_TMIO_CORE
 	help
 	  This provides support for the SDHI SD/SDIO controller found in
-- 
1.7.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ