linux-kernel - Re: [Meego-kernel] [PATCH v9 1/2] mrst: export get_gpio_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110328104615.52c6c03c@lxorguk.ukuu.org.uk>
Date:	Mon, 28 Mar 2011 10:46:15 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Arjan van de Ven <arjan@...ux.intel.com>
Cc:	Feng Tang <feng.tang@...el.com>,
	Feng Tang <feng.tang@...ux.intel.com>,
	"x86@...nel.org" <x86@...nel.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...hat.com>,
	"Kp, Jeeja" <jeeja.kp@...el.com>,
	"Fu, Michael" <michael.fu@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Wu, Fengguang" <fengguang.wu@...el.com>,
	"meego-kernel@...ts.meego.com" <meego-kernel@...ts.meego.com>
Subject: Re: [Meego-kernel] [PATCH v9 1/2] mrst: export get_gpio_by_name()
 function

> Medfield and MRST are targeting phones. MIDs don't exist... not in this 
> decade.

Well you can take that up with everyone else somewhere offlist, but the
standard naming being used for these devices as a group is mid_xxx, and
has been in the kernel several releases.

> if it was renamed to sfi_get_gpio_by_name() it might make SOME sense, 
> but even then it's a
> gratuitous rename for a function that's already in the upstream kernel.

1. It needs a name that won't clash with anything else or confuse people

2. It shouldn't be exported in the first place but appearing in the PCI
data for the device.

If it must be exported then it definitely needs a rename.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/