linux-kernel - Re: [PATCH] ata: pata_at91.c bugfix for initial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1301314170.3182.15.camel@edumazet-laptop>
Date:	Mon, 28 Mar 2011 14:09:30 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Igor Plyatov <plyatov@...il.com>
Cc:	Jeff Garzik <jgarzik@...ox.com>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ata: pata_at91.c bugfix for initial_timing
 initialisation

Le lundi 28 mars 2011 à 15:59 +0400, Igor Plyatov a écrit :
> The "struct ata_timing" must contain 10 members, but ".dmack_hold" member was
> forgotten for "initial_timing" initialisation. This patch fixes such a problem.
> 
> Signed-off-by: Igor Plyatov <plyatov@...il.com>
> ---
>  drivers/ata/pata_at91.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c
> index 0da0dcc..d1aaeb5 100644
> --- a/drivers/ata/pata_at91.c
> +++ b/drivers/ata/pata_at91.c
> @@ -49,8 +49,9 @@ struct at91_ide_info {
>  	void __iomem *alt_addr;
>  };
>  
> -static const struct ata_timing initial_timing =
> -	{XFER_PIO_0, 70, 290, 240, 600, 165, 150, 600, 0};
> +static const struct ata_timing initial_timing = {
> +	XFER_PIO_0, 70, 290, 240, 600, 165, 150, 600, 0

Oh well.

	XFER_PIO_0, 70, 290, 240, 600, 165, 150, 0, 600, 0

Or even better, use C99 initializer ?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/