linux-kernel - Re: [PATCH] memcg: fix mem_cgroup_rotate_reclaimable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110328134540.GD1892@barrios-desktop>
Date:	Mon, 28 Mar 2011 22:45:40 +0900
From:	Minchan Kim <minchan.kim@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Johannes Weiner <hannes@...xchg.org>,
	linux-mm <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Steven Barrett <damentz@...uorix.net>,
	Ben Gamari <bgamari.foss@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Rik van Riel <riel@...hat.com>, Mel Gorman <mel@....ul.ie>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Wu Fengguang <fengguang.wu@...el.com>,
	Nick Piggin <npiggin@...nel.dk>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Subject: Re: [PATCH] memcg: fix mem_cgroup_rotate_reclaimable_page

On Mon, Mar 28, 2011 at 02:51:46PM +0200, Eric Dumazet wrote:
> Le mardi 22 février 2011 à 00:59 +0900, Minchan Kim a écrit :
> > Fixed version.
> > 
> > From be7d31f6e539bbad1ebedf52c6a51a4a80f7976a Mon Sep 17 00:00:00 2001
> > From: Minchan Kim <minchan.kim@...il.com>
> > Date: Tue, 22 Feb 2011 00:53:05 +0900
> > Subject: [PATCH v7 2/3] memcg: move memcg reclaimable page into tail of inactive list
> > 
> > The rotate_reclaimable_page function moves just written out
> > pages, which the VM wanted to reclaim, to the end of the
> > inactive list.  That way the VM will find those pages first
> > next time it needs to free memory.
> > This patch apply the rule in memcg.
> > It can help to prevent unnecessary working page eviction of memcg.
> > 
> > Acked-by: Balbir Singh <balbir@...ux.vnet.ibm.com>
> > Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> > Reviewed-by: Rik van Riel <riel@...hat.com>
> > Cc: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
> > Cc: Johannes Weiner <hannes@...xchg.org>
> > Signed-off-by: Minchan Kim <minchan.kim@...il.com>
> > ---
> 
> Hmm... "inline inline" is an error on some gcc versions
> 
>   CC      arch/x86/kernel/asm-offsets.s
> In file included from include/linux/swap.h:8,
>                  from include/linux/suspend.h:4,
>                  from arch/x86/kernel/asm-offsets.c:12:
> include/linux/memcontrol.h:220: error: duplicate `inline'
> make[1]: *** [arch/x86/kernel/asm-offsets.s] Error 1
> 
> 
> > +static inline inline void mem_cgroup_rotate_reclaimable_page(struct page *page)
> > +{
> > +	return ;
> > +}
> > +
> 
> [PATCH] memcg: fix mem_cgroup_rotate_reclaimable_page proto
> 
> commit 3f58a8294333 (move memcg reclaimable page into tail of inactive
> list) added inline keyword twice in its prototype.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Cc: Minchan Kim <minchan.kim@...il.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Balbir Singh <balbir@...ux.vnet.ibm.com>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> Cc: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
> Cc: Johannes Weiner <hannes@...xchg.org>
Reviewed-by: Minchan Kim <minchan.kim@...il.com>

It a was totally my fault.
Thanks very much. 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/