linux-kernel - Re: [PATCH] fbcon: Remove unused 'display *p' variable from fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110328091846.485dfef0@jbarnes-desktop>
Date:	Mon, 28 Mar 2011 09:18:46 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Cc:	Paul Mundt <lethal@...ux-sh.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Dave Airlie <airlied@...hat.com>, linux-fbdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fbcon: Remove unused 'display *p' variable from
 fb_flashcursor()

On Thu, 24 Mar 2011 22:50:52 +0200
Sergey Senozhatsky <sergey.senozhatsky@...il.com> wrote:

> fbcon: Remove unused 'display *p' variable from fb_flashcursor()
> 
> Signed-of-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> 
> ---
> 
>  drivers/video/console/fbcon.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
> index c583934..8745637 100644
> --- a/drivers/video/console/fbcon.c
> +++ b/drivers/video/console/fbcon.c
> @@ -370,7 +370,6 @@ static void fb_flashcursor(struct work_struct *work)
>  {
>  	struct fb_info *info = container_of(work, struct fb_info, queue);
>  	struct fbcon_ops *ops = info->fbcon_par;
> -	struct display *p;
>  	struct vc_data *vc = NULL;
>  	int c;
>  	int mode;
> @@ -386,7 +385,6 @@ static void fb_flashcursor(struct work_struct *work)
>  		return;
>  	}
>  
> -	p = &fb_display[vc->vc_num];
>  	c = scr_readw((u16 *) vc->vc_pos);
>  	mode = (!ops->cursor_flash || ops->cursor_state.enable) ?
>  		CM_ERASE : CM_DRAW;

Looks fine to me, is Paul the lucky owner of fbdev now?

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/