linux-kernel - Re: [Patch] proc: check error pointer returned by m

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=mqKF=xeMYbj9LZgPfSLHSkO1JRXsNTW3LyHqu@mail.gmail.com>
Date:	Sun, 27 Mar 2011 20:58:10 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Amerigo Wang <amwang@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Al Viro <viro@...iv.linux.org.uk>,
	WANG Cong <xiyou.wangcong@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Eric B Munson <emunson@...bm.net>,
	David Rientjes <rientjes@...gle.com>,
	Dave Hansen <dave@...ux.vnet.ibm.com>,
	Mel Gorman <mel@....ul.ie>
Subject: Re: [Patch] proc: check error pointer returned by m_start()

On Sun, Mar 27, 2011 at 8:46 PM, Amerigo Wang <amwang@...hat.com> wrote:
>
> This is true, that commit changed the return value of m_start(),
> which will return an error pointer on failure, but Al forgot
> to check the error pointer in m_stop() which will be called
> when m_start() fails. This patches fixes it.

I did this slightly differently, and put the check in m_stop()
instead, because I felt that matched the logic of m_start, while
vma_stop() is more of an internal helper thing.

I dunno. I don't think it matters. But one thing I reacted to was that
when I was walking through the logic, I really wanted to say "seq_file
is wrong to call m_stop if m_start returned an error code". I really
felt like "hwy, if ->start fails, we damn well shouldn't have called
->stop".

But I guess we're stuck with that particular semantic for seq_files by now.

                         Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/