linux-kernel - Re: [PATCH] acpi: Remove sysfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201103282122.21175.rjw@sisk.pl>
Date:	Mon, 28 Mar 2011 21:22:21 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Matthew Garrett <mjg@...hat.com>
Cc:	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	jeff.chua.linux@...il.com
Subject: Re: [PATCH] acpi: Remove sysfs_create_link from video driver

On Monday, March 28, 2011, Matthew Garrett wrote:
> The acpi video driver attempts to explicitly create a sysfs link between
> the acpi device and the associated PCI device. However, we're now also
> doing this from the backlight core, which means that we get a backtrace
> caused by a duplicate file. Remove the code and leave it up to the
> backlight core.
> 
> Reported-by: Jeff Chua <jeff.chua.linux@...il.com>
> Signed-off-by: Matthew Garrett <mjg@...hat.com>

Acked-by: Rafael J. Wysocki <rjw@...k.pl>

> ---
>  drivers/acpi/video.c |    6 ------
>  1 files changed, 0 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> index a18e497..31e9e10 100644
> --- a/drivers/acpi/video.c
> +++ b/drivers/acpi/video.c
> @@ -824,11 +824,6 @@ static void acpi_video_device_find_cap(struct acpi_video_device *device)
>  		device->backlight->props.brightness =
>  				acpi_video_get_brightness(device->backlight);
>  
> -		result = sysfs_create_link(&device->backlight->dev.kobj,
> -					   &device->dev->dev.kobj, "device");
> -		if (result)
> -			printk(KERN_ERR PREFIX "Create sysfs link\n");
> -
>  		device->cooling_dev = thermal_cooling_device_register("LCD",
>  					device->dev, &video_cooling_ops);
>  		if (IS_ERR(device->cooling_dev)) {
> @@ -1381,7 +1376,6 @@ static int acpi_video_bus_put_one_device(struct acpi_video_device *device)
>  		       "Cant remove video notify handler\n");
>  	}
>  	if (device->backlight) {
> -		sysfs_remove_link(&device->backlight->dev.kobj, "device");
>  		backlight_device_unregister(device->backlight);
>  		device->backlight = NULL;
>  	}
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/