lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20110328050256.GB2158@gmail.com>
Date:	Mon, 28 Mar 2011 13:02:58 +0800
From:	Harry Wei <jiaweiwei.xiyou@...il.com>
To:	wanlong.gao@...il.com
Cc:	linux-kernel@...r.kernel.org, greg@...ah.com
Subject: Re: [PATCH] Fixed the format error for unnecessary spaces or
 required spaces.

On Sun, Mar 27, 2011 at 10:45:20AM +0800, wanlong.gao@...il.com wrote:
> From: Wanlong Gao <wanlong.gao@...il.com>
> 
> Better has no spaces at the start of a line
> 	FILE: ab3100-core.c:372
> 
> Better has no space before tabs
> 	FILE: adp5520.c:361
> 
> Space required after that ','
> 	FILE: dm355evm_msp.c:97
> 
> Signed-off-by: Wanlong Gao <wanlong.gao@...il.com>
Acked-by: Harry Wei <harryxiyou@...il.com>
> ---
>  drivers/mfd/ab3100-core.c  |    2 +-
>  drivers/mfd/adp5520.c      |    2 +-
>  drivers/mfd/dm355evm_msp.c |    2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/ab3100-core.c b/drivers/mfd/ab3100-core.c
> index 4193af5..010b358 100644
> --- a/drivers/mfd/ab3100-core.c
> +++ b/drivers/mfd/ab3100-core.c
> @@ -369,7 +369,7 @@ EXPORT_SYMBOL(ab3100_event_register);
>  int ab3100_event_unregister(struct ab3100 *ab3100,
>  			    struct notifier_block *nb)
>  {
> -  return blocking_notifier_chain_unregister(&ab3100->event_subscribers,
> +	return blocking_notifier_chain_unregister(&ab3100->event_subscribers,
>  					    nb);
>  }
>  EXPORT_SYMBOL(ab3100_event_unregister);
> diff --git a/drivers/mfd/adp5520.c b/drivers/mfd/adp5520.c
> index 3122139..ccf6dc3 100644
> --- a/drivers/mfd/adp5520.c
> +++ b/drivers/mfd/adp5520.c
> @@ -358,7 +358,7 @@ static struct i2c_driver adp5520_driver = {
>  	.remove		= __devexit_p(adp5520_remove),
>  	.suspend	= adp5520_suspend,
>  	.resume		= adp5520_resume,
> -	.id_table 	= adp5520_id,
> +	.id_table	= adp5520_id,
>  };
>  
>  static int __init adp5520_init(void)
> diff --git a/drivers/mfd/dm355evm_msp.c b/drivers/mfd/dm355evm_msp.c
> index 3d4a861..7ebe68b 100644
> --- a/drivers/mfd/dm355evm_msp.c
> +++ b/drivers/mfd/dm355evm_msp.c
> @@ -94,7 +94,7 @@ EXPORT_SYMBOL(dm355evm_msp_read);
>   * Many of the msp430 pins are just used as fixed-direction GPIOs.
>   * We could export a few more of them this way, if we wanted.
>   */
> -#define MSP_GPIO(bit,reg)	((DM355EVM_MSP_ ## reg) << 3 | (bit))
> +#define MSP_GPIO(bit, reg)	((DM355EVM_MSP_ ## reg) << 3 | (bit))
>  
>  static const u8 msp_gpios[] = {
>  	/* eight leds */
> -- 
> 1.7.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ