linux-kernel - Re: [Patch V2] proc: check error pointer returned by m

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D902155.8040602@redhat.com>
Date:	Mon, 28 Mar 2011 13:49:09 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Anca Emanuel <anca.emanuel@...il.com>
CC:	linux-kernel@...r.kernel.org, WANG Cong <xiyou.wangcong@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Eric B Munson <emunson@...bm.net>,
	David Rientjes <rientjes@...gle.com>,
	Dave Hansen <dave@...ux.vnet.ibm.com>,
	Mel Gorman <mel@....ul.ie>, linux-fsdevel@...r.kernel.org
Subject: Re: [Patch V2] proc: check error pointer returned by m_start()

于 2011年03月28日 13:46, Anca Emanuel 写道:
> On Mon, Mar 28, 2011 at 8:26 AM, Amerigo Wang<amwang@...hat.com>  wrote:
>> From: WANG Cong<xiyou.wangcong@...il.com>
>>
>> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
>> index 7c708a4..8e59169 100644
>> --- a/fs/proc/task_mmu.c
>> +++ b/fs/proc/task_mmu.c
>> @@ -124,8 +124,10 @@ static void *m_start(struct seq_file *m, loff_t *pos)
>>                 return ERR_PTR(-ESRCH);
>>
>>         mm = mm_for_maps(priv->task);
>> -       if (!mm || IS_ERR(mm))
>> +       if (IS_ERR_OR_NULL(mm)) {
>> +               put_task_struct(priv->task);
>>                 return mm;
>> +       }
>>         down_read(&mm->mmap_sem);
>>
>>         tail_vma = get_gate_vma(priv->task->mm);
>> @@ -182,6 +184,8 @@ static void m_stop(struct seq_file *m, void *v)
>>         struct proc_maps_private *priv = m->private;
>>         struct vm_area_struct *vma = v;
>>
>> +       if (IS_ERR_OR_NULL(v))
>> +               return;
>
> Note: this is not functional equivalent with the previous patch.
>

I moved that put_task_struct() into m_start() itself.

>
> I din't test the above patch.
>
> Linus already have the fix in his tree.

Yes, I really should pull before I made a patch. :-/

Anyway, thanks for reporting and testing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/