linux-kernel - [tip:x86/urgent] x86, microcode: Unregister syscore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-4ac5fc6a3e4d90120f292526bcaa5ee182a7411b@git.kernel.org>
Date:	Tue, 29 Mar 2011 09:17:07 GMT
From:	tip-bot for Xiaotian Feng <dfeng@...hat.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	tigran@...azian.fsnet.co.uk, tglx@...utronix.de, rjw@...k.pl,
	dfeng@...hat.com, mingo@...e.hu
Subject: [tip:x86/urgent] x86, microcode: Unregister syscore_ops after microcode unloaded

Commit-ID:  4ac5fc6a3e4d90120f292526bcaa5ee182a7411b
Gitweb:     http://git.kernel.org/tip/4ac5fc6a3e4d90120f292526bcaa5ee182a7411b
Author:     Xiaotian Feng <dfeng@...hat.com>
AuthorDate: Tue, 29 Mar 2011 16:34:32 +0800
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Tue, 29 Mar 2011 11:12:04 +0200

x86, microcode: Unregister syscore_ops after microcode unloaded

Currently, microcode doesn't unregister syscore_ops after it's
unloaded. So if we modprobe then rmmod microcode, the stale
microcode syscore_ops info will stay on syscore_ops_list.

Later when we're trying to reboot/halt/shutdown the machine, kernel
will panic on syscore_shutdown().

With the patch applied, I can reboot/halt/shutdown my machine successfully.

Signed-off-by: Xiaotian Feng <dfeng@...hat.com>
Cc: Tigran Aivazian <tigran@...azian.fsnet.co.uk>
Cc: Rafael J. Wysocki <rjw@...k.pl>
LKML-Reference: <1301387672-23661-1-git-send-email-dfeng@...hat.com>
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 arch/x86/kernel/microcode_core.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/microcode_core.c b/arch/x86/kernel/microcode_core.c
index 5ed0ab5..f924280 100644
--- a/arch/x86/kernel/microcode_core.c
+++ b/arch/x86/kernel/microcode_core.c
@@ -550,6 +550,7 @@ static void __exit microcode_exit(void)
 	microcode_dev_exit();
 
 	unregister_hotcpu_notifier(&mc_cpu_notifier);
+	unregister_syscore_ops(&mc_syscore_ops);
 
 	get_online_cpus();
 	mutex_lock(&microcode_mutex);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/