linux-kernel - Re: [GIT PATCH 2/3] Resend : Fix memory leak in qcserial driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Mar 2011 15:22:05 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Steven Hardy <shardy@...hat.com>
CC:	Greg KH <gregkh@...e.de>, mjg@...hat.com,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [GIT PATCH 2/3] Resend : Fix memory leak in qcserial driver

Hello.

On 28-03-2011 21:38, Steven Hardy wrote:

    Posting all 3 patches having the same sucject is not a good idea.

> Patch 2 of 3, addresses the problem where serial->private can end up pointing to freed memory in the event qcprobe fails & returns -ENODEV

    You still didn't wrap the changelog text properly.

> Original description:
> 3 - Don't assign serial->private when doing the kzalloc or serial->private ends up pointing to freed memory in the event we return -ENODEV, instead call usb_set_serial_data(serial, data) at the end of the function, and only have one return-point.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/