| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20110328.175849.112593455.davem@davemloft.net> Date: Mon, 28 Mar 2011 17:58:49 -0700 (PDT) From: David Miller <davem@...emloft.net> To: a.p.zijlstra@...llo.nl Cc: paulus@...ba.org, mingo@...e.hu, acme@...stprotocols.net, linux-kernel@...r.kernel.org Subject: [PATCH] perf: Properly align symbol_conf.priv_size If symbol_conf.priv_size is not a multiple of "sizeof(u64)" we'll bus error on sparc64 in symbol__new because the "struct symbol *" pointer is computed by adding symbol_conf.priv_size to the memory allocated. We cannot isloate the fix to symbol__new and symbol__delete since the private area is computed by subtracting the priv_size value from a "struct symbol" pointer, so then the private area can still be potentially unaligned. So, simply align the symbol_conf.priv_size value in symbol__init() Signed-off-by: David S. Miller <davem@...emloft.net> diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index 17df793..76c09099 100644 --- a/tools/perf/util/symbol.c +++ b/tools/perf/util/symbol.c @@ -2403,6 +2403,8 @@ int symbol__init(void) if (symbol_conf.initialized) return 0; + symbol_conf.priv_size = ALIGN(symbol_conf.priv_size, sizeof(u64)); + elf_version(EV_CURRENT); if (symbol_conf.sort_by_name) symbol_conf.priv_size += (sizeof(struct symbol_name_rb_node) - -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists