linux-kernel - Re: [PATCH 1/6] TTY: unify tty_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D91CDE6.9060006@suse.cz>
Date:	Tue, 29 Mar 2011 14:17:42 +0200
From:	Jiri Slaby <jslaby@...e.cz>
To:	Julian Anastasov <ja@....bg>
CC:	gregkh@...e.de, jirislaby@...il.com, linux-kernel@...r.kernel.org,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH 1/6] TTY: unify tty_init_dev fail path handling

On 03/23/2011 09:53 PM, Julian Anastasov wrote:
> 
>     Hello,
> 
> On Wed, 23 Mar 2011, Jiri Slaby wrote:
> 
>> Change it so that we call the deinit functions at one place at the end
>> of the function (by gotos). And while at it use some sane label names.
>>
>> This is a preparation for the deinitialization of tty in the next
>> patch.
>>
>> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
>> Cc: Greg Kroah-Hartman <gregkh@...e.de>
>> Cc: Alan Cox <alan@...rguk.ukuu.org.uk>
>> Cc: Julian Anastasov <ja@....bg>
>> ---
>>
>> This is not tested yet, I'm building a kernel to test it a bit, but it
>> will take some time. If you could too to check if your problem
>> dissapears, it would be great.
> 
>     Thanks! Patches 1-5 work for me, I backported them
> to 2.6.33.8 for the test.

Thanks for testing. I see no regressions either.

Greg, will you take it?

regards,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/