linux-kernel - Re: [GIT PATCH 2/3 (2nd draft)] Resend : Fix memory leak in qcserial driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Mar 2011 09:22:16 -0400
From:	Aristeu Rozanski <aris@...hat.com>
To:	Steven Hardy <shardy@...hat.com>
Cc:	Greg KH <gregkh@...e.de>, mjg@...hat.com,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [GIT PATCH 2/3 (2nd draft)] Resend : Fix memory leak in qcserial
 driver

On Mon, Mar 28, 2011 at 11:16:37PM +0100, Steven Hardy wrote:
> +	/* Set serial->private if not returning -ENODEV */
> +	if ( retval != -ENODEV )
            ^                 ^
coding style
> +		usb_set_serial_data(serial, data);
>  	return retval;
>  }
the rest looks good to me.

-- 
Aristeu

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/