linux-kernel - RE: [PATCH] unicore32 rtc driver fix: cleanup irq_set_freq and irq_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <019901cbee20$78c93ed0$6a5bbc70$@mprc.pku.edu.cn>
Date:	Tue, 29 Mar 2011 22:49:12 +0800
From:	"Guan Xuetao" <gxt@...c.pku.edu.cn>
To:	<a.zummo@...ertech.it>, "john stultz" <johnstul@...ibm.com>,
	"Thomas Gleixner" <tglx@...utronix.de>
Cc:	"Arnd Bergmann" <arnd@...db.de>, <linux-kernel@...r.kernel.org>,
	<rtc-linux@...glegroups.com>
Subject: RE: [PATCH] unicore32 rtc driver fix: cleanup irq_set_freq and irq_set_state

While modifying my code, I found something error to the modification for drivers/rtc/rtc-s3c.c.
When cleanup irq_set_state,  s3c_rtc_setpie() is removed.
However, the function is still used inside the file.

Guan Xuetao

> -----Original Message-----
> From: Guan Xuetao [mailto:gxt@...c.pku.edu.cn]
> Sent: Tuesday, March 29, 2011 10:44 PM
> To: 'a.zummo@...ertech.it'; john stultz (johnstul@...ibm.com); Thomas Gleixner (tglx@...utronix.de)
> Cc: Arnd Bergmann (arnd@...db.de); 'Guan Xuetao' (gxt@...c.pku.edu.cn); 'linux-kernel@...r.kernel.org'; 'rtc-
> linux@...glegroups.com'
> Subject: [PATCH] unicore32 rtc driver fix: cleanup irq_set_freq and irq_set_state
> 
> 
> Signed-off-by: Guan Xuetao <gxt@...c.pku.edu.cn>
> ---
>  arch/unicore32/kernel/rtc.c |    9 ---------
>  1 files changed, 0 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/unicore32/kernel/rtc.c b/arch/unicore32/kernel/rtc.c
> index c5f0682..8cad70b 100644
> --- a/arch/unicore32/kernel/rtc.c
> +++ b/arch/unicore32/kernel/rtc.c
> @@ -88,11 +88,6 @@ static int puv3_rtc_setpie(struct device *dev, int enabled)
>  	return 0;
>  }
> 
> -static int puv3_rtc_setfreq(struct device *dev, int freq)
> -{
> -	return 0;
> -}
> -
>  /* Time read/write */
> 
>  static int puv3_rtc_gettime(struct device *dev, struct rtc_time *rtc_tm)
> @@ -214,8 +209,6 @@ static const struct rtc_class_ops puv3_rtcops = {
>  	.set_time	= puv3_rtc_settime,
>  	.read_alarm	= puv3_rtc_getalarm,
>  	.set_alarm	= puv3_rtc_setalarm,
> -	.irq_set_freq	= puv3_rtc_setfreq,
> -	.irq_set_state	= puv3_rtc_setpie,
>  	.proc	        = puv3_rtc_proc,
>  };
> 
> @@ -294,8 +287,6 @@ static int puv3_rtc_probe(struct platform_device *pdev)
> 
>  	puv3_rtc_enable(pdev, 1);
> 
> -	puv3_rtc_setfreq(&pdev->dev, 1);
> -
>  	/* register RTC and exit */
> 
>  	rtc = rtc_device_register("pkunity", &pdev->dev, &puv3_rtcops,
> --
> 1.6.2.2


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/