linux-kernel - Re: [PATCH 05/30] amd64_edac: Cleanup chipselect handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D91F31A.7040600@redhat.com>
Date:	Tue, 29 Mar 2011 11:56:26 -0300
From:	Mauro Carvalho Chehab <mchehab@...hat.com>
To:	Borislav Petkov <bp@...64.org>
CC:	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
	Borislav Petkov <borislav.petkov@....com>
Subject: Re: [PATCH 05/30] amd64_edac: Cleanup chipselect handling

Em 10-02-2011 15:15, Borislav Petkov escreveu:
> From: Borislav Petkov <borislav.petkov@....com>
> 
> Add a struct representing the DRAM chip select base/limit register
> pairs. Concentrate all CS handling in a single function. Also, add CS
> looping macros for cleaner, more readable code. While at it, adjust code
> to F15h. Finally, do smaller macro names cleanups (remove family names
> from register macros) and debug messages clarification.
> 
> No functional change.
> 
> Signed-off-by: Borislav Petkov <borislav.petkov@....com>

Hi Borislav,

> --- a/drivers/edac/amd64_edac.h
> +++ b/drivers/edac/amd64_edac.h
> @@ -160,6 +160,14 @@
>  #define OFF false
>  
>  /*
> + * Create a contiguous bitmask starting at bit position @lo and ending at
> + * position @hi. For example
> + *
> + * GENMASK(21, 39) gives us the 64bit vector 0x000000ffffe00000.
> + */
> +#define GENMASK(lo, hi)			(((1ULL << ((hi) - (lo) + 1)) - 1) << (lo))
> +

This is a nice macro that could be useful outside amd64. It is probably a good
idea to move it to include/linux/bitops.h.

Cheers,
Mauro.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/