linux-kernel - Re: [PATCH] Fix build failure when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8739m5519p.fsf@devron.myhome.or.jp>
Date:	Wed, 30 Mar 2011 01:39:46 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Shyam_Iyer@...l.com, jbarnes@...tuousgeek.org, mjg59@...f.ucam.org,
	Narendra_K@...l.com, viro@...iv.linux.org.uk, sfr@...b.auug.org.au,
	linux-kernel@...r.kernel.org, linux-next@...r.kernel.org,
	Matt_Domsch@...l.com, Charles_Rose@...l.com,
	Jordan_Hargrave@...l.com
Subject: Re: [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig

Randy Dunlap <randy.dunlap@...cle.com> writes:

>> config PCI_LABEL
>> 	bool
>>         select NLS
>>         depends on (DMI || ACPI)
>
> What sets/enables it then?
> or did you mean:
> 	def_bool y
> and in that case, should it be a user-visible & user-changeable kconfig option?

Whoops, last line was missed by copy&paste. It meant

config PCI_LABEL
	bool
	select NLS
	depends on (DMI || ACPI)
        default y

And no, it shouldn't be user-changeable (it would be better to
invisible in .config. At make *config, already invisible.). Because
PCI_LABEL is not user config and not used in Makefile.

And yeah, if you like def_bool

config PCI_LABEL
	def_bool y if (DMI || ACPI)
	select NLS

I guess it would work (it should be just syntax sugar and equivalent).

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/