linux-kernel - Re: Please revert a91a2785b20

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D918347.7050500@fusionio.com>
Date:	Tue, 29 Mar 2011 08:59:19 +0200
From:	Jens Axboe <jaxboe@...ionio.com>
To:	Mike Snitzer <snitzer@...hat.com>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	James Bottomley <James.Bottomley@...e.de>,
	"Rafael J. Wysocki" <rjw@...k.pl>, Ingo Molnar <mingo@...e.hu>
Subject: Re: Please revert a91a2785b20

On 2011-03-29 01:03, Mike Snitzer wrote:
> On Mon, Mar 28 2011 at  6:43pm -0400,
> Thomas Gleixner <tglx@...utronix.de> wrote:
> 
>> Forgot to cc Jens and fixed up the borked mail address of Mike which
>> I took from the changelog :(
>>
>> On Tue, 29 Mar 2011, Thomas Gleixner wrote:
>>
>>> Out of the blue all my perfectly fine working test machines which use
>>> RAID stopped working with the very helpful error message:
>>>
>>> 	md/raid1:md1: active with 2 out of 2 mirrors
>>> 	md: pers->run() failed ...
>>>
>>> Reverting a91a2785b20 fixes the problem.
>>>
>>> Neither the subject line:
>>>
>>>  block: Require subsystems to explicitly allocate bio_set integrity mempool
>>>
>>> nor the changelog have any hint why that wreckage is in any way
>>> sensible.
>>>
>>> The wreckage happens due to:
>>>
>>> -       md_integrity_register(mddev);
>>> -       return 0;
>>> +       return md_integrity_register(mddev);
> 
> Right, a kernel.org BZ was filed on this here:
> https://bugzilla.kernel.org/show_bug.cgi?id=32062
> 
> Martin is working to "conjure up a patch" to fix the common case where
> no devices in the MD have DIF/DIX capabilities.

And I see that has been merged now. So all is good?

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/