linux-kernel - Re: [PATCH] ubifs: fix kconfig dependency warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1301382178.2816.69.camel@localhost>
Date:	Tue, 29 Mar 2011 10:02:58 +0300
From:	Artem Bityutskiy <dedekind1@...il.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	lkml <linux-kernel@...r.kernel.org>, linux-mtd@...ts.infradead.org,
	Adrian Hunter <adrian.hunter@...ia.com>
Subject: Re: [PATCH] ubifs: fix kconfig dependency warning

On Mon, 2011-03-28 at 13:40 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Fix another kconfig dependency warning, this time in ubifs.
> 
> warning: (UBIFS_FS_DEBUG && LOCKDEP && LATENCYTOP) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)
> 
> Without this patch, we can have:
> # CONFIG_KALLSYMS is not set
> CONFIG_KALLSYMS_ALL=y
> which is useless (does nothing unless KALLSYMS is enabled).
> 
> However, ubifs builds successfully with or without this patch,
> and it builds with this line completely deleted,
> so what was this 'select' for?  Just developer convenience?

Well, here is the idea. You can compile UBIFS with debugging and without
debugging. Without debugging the resulting ubifs.ko is much smaller, so
some embedded people prefer it this way.

If you select debugging support, then we'll compile it a lot of
assertions, self-checks, test-modes, extra error messages with detailed
dumps. And we want to see stackdumps when errors or problems happen,
this is why we select KALLSYMS_ALL.

So I guess instead we should do:

select KALLSYMS
select KALLSYMS_ALL

?

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/