linux-kernel - Re: [PATCH] proc: constify status array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTin6cZQhnkPgsA8Um9vMxjNoAGmu8mtgEP9Eb8Ni@mail.gmail.com>
Date:	Wed, 30 Mar 2011 06:03:11 -0400
From:	Mike Frysinger <vapier@...too.org>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] proc: constify status array

On Wed, Mar 30, 2011 at 05:56, Alexey Dobriyan wrote:
> On Wed, Mar 30, 2011 at 9:09 AM, Mike Frysinger wrote:
>> -static const char *task_state_array[] = {
>> +static const char * const task_state_array[] = {
>
> Why this is needed for task_state_array, but not for, say, tgid_base_stuff?

tgid_base_stuff is already declared const.  which your nm output clearly shows.

> This double const is ugly.

quite the opposite.  not declaring const arrays const is ugly.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/