linux-kernel - Re: [PATCH 07/18] gma500: Add Moorestown backlight support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110330103324.GA29796@srcf.ucam.org>
Date:	Wed, 30 Mar 2011 11:33:24 +0100
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Alan Cox <alan@...ux.intel.com>
Cc:	greg@...ah.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/18] gma500: Add Moorestown backlight support

On Wed, Mar 30, 2011 at 10:00:05AM +0100, Alan Cox wrote:

> +	/* Percentage 1-100% being valid */
> +	if (level < 1)
> +		level = 1;

I know you're not actually changing anything here, but opregion supports 
requesting brightnesses between 0 and 255 - it'd be easier if we only 
had one level of scaling, rather than having to map that to a percentage 
only for it to be remapped to the hardware.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/