linux-kernel - Re: [PATCH] blk-throttle: don't call xchg on bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110330131936.GA1291@redhat.com>
Date:	Wed, 30 Mar 2011 09:19:36 -0400
From:	Vivek Goyal <vgoyal@...hat.com>
To:	Andreas Schwab <schwab@...ux-m68k.org>
Cc:	linux-kernel@...r.kernel.org, jaxboe@...ionio.com,
	paulmck@...ux.vnet.ibm.com, oleg@...hat.com
Subject: Re: [PATCH] blk-throttle: don't call xchg on bool

On Wed, Mar 30, 2011 at 01:14:50AM +0200, Andreas Schwab wrote:
> xchg does not work portably with smaller than 32bit types.
> 

Hi Andreas,

Which arch creates the problem and what's the issue here if data type
is smaller than 32bit? Is it a compile time warning?

Also, you also probably need to chagne ->limits_changed assignments?
Instead of using true/false use 1/0.

Thanks
Vivek

> Signed-off-by: Andreas Schwab <schwab@...ux-m68k.org>
> ---
>  block/blk-throttle.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/block/blk-throttle.c b/block/blk-throttle.c
> index 5352bda..6c98cfe 100644
> --- a/block/blk-throttle.c
> +++ b/block/blk-throttle.c
> @@ -77,7 +77,7 @@ struct throtl_grp {
>  	unsigned long slice_end[2];
>  
>  	/* Some throttle limits got updated for the group */
> -	bool limits_changed;
> +	int limits_changed;
>  };
>  
>  struct throtl_data
> @@ -102,7 +102,7 @@ struct throtl_data
>  	/* Work for dispatching throttled bios */
>  	struct delayed_work throtl_work;
>  
> -	bool limits_changed;
> +	int limits_changed;
>  };
>  
>  enum tg_state_flags {
> -- 
> 1.7.4.2
> 
> 
> -- 
> Andreas Schwab, schwab@...ux-m68k.org
> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
> "And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/