linux-kernel - Re: [PATCH] pch_gpio: Fix output value of pch_gpio_direction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1301496403.24947.8543.camel@petert>
Date:	Wed, 30 Mar 2011 09:46:43 -0500
From:	Peter Tyser <ptyser@...-inc.com>
To:	Tomoya MORINAGA <tomoya-linux@....okisemi.com>
Cc:	linux-kernel@...r.kernel.org, qi.wang@...el.com,
	yong.y.wang@...el.com, joel.clark@...el.com,
	kok.howg.ewe@...el.com, toshiharu-linux@....okisemi.com
Subject: Re: [PATCH] pch_gpio: Fix output value of
 pch_gpio_direction_output()

On Wed, 2011-03-30 at 21:16 +0900, Tomoya MORINAGA wrote:
> The pch_gpio_direction_output() function was missing a write to set the
> desired output value.  The function would properly set the GPIO
> direction, but not the output value.  The value would have to manually
> be set with a follow up call to pch_gpio_set().
> 
> Add the missing write so that pch_gpio_direction_output() sets both the
> GPIO direction and value.
> 
> Reported-by: Peter Tyser <ptyser@...-inc.com>
> Signed-off-by: Tomoya MORINAGA <tomoya-linux@....okisemi.com>

Hi Tomoya,
I posted this same patch last week:
https://patchwork.kernel.org/patch/662621/

It looks like this driver and the ml_ioh_gpio driver are nearly
identical, hence the identical fixes.  If you have some spare cycles
it'd be nice to combine them.

Best,
Peter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/